Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix workflow configmap argument cannot be referenced as local variable. Fixes #6869 #6898

Merged
merged 3 commits into from
Oct 19, 2021
Merged

feat: fix workflow configmap argument cannot be referenced as local variable. Fixes #6869 #6898

merged 3 commits into from
Oct 19, 2021

Conversation

smile-luobin
Copy link
Contributor

Signed-off-by: smile-luobin luobin_smile@163.com

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismis the review to get it looked at again.
  • You can ask for help!

@smile-luobin
feat: fix workflow configmap argument cannot be referenced as local v…
ee4f459 
…ariable; fixes-6869

Signed-off-by: smile-luobin <luobin_smile@163.com>
@smile-luobin smile-luobin mentioned this pull request Oct 9, 2021
Closed
@codecov
Copy link

codecov bot commented Oct 9, 2021 •
edited
Loading

Codecov Report

Merging #6898 (a48a460) into master (2fd4b8a) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head a48a460 differs from pull request most recent head 86e06bb. Consider uploading reports for the commit 86e06bb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6898      +/-   ##
==========================================
- Coverage   48.53%   48.47%   -0.07%     
==========================================
  Files         265      265              
  Lines       19259    19262       +3     
==========================================
- Hits         9348     9337      -11     
- Misses       8860     8876      +16     
+ Partials     1051     1049       -2
Impacted Files Coverage Δ
workflow/common/util.go 14.36% <0.00%> (-0.24%) ⬇️
server/workflow/workflow_server.go 44.41% <0.00%> (-2.40%) ⬇️
cmd/argo/commands/get.go 59.18% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd4b8a...86e06bb. Read the comment docs.

@smile-luobin smile-luobin changed the title feat: fix workflow configmap argument cannot be referenced as local variable; fixes-6869 feat: fix workflow configmap argument cannot be referenced as local variable. Fixes #6869 Oct 9, 2021
@terrytangyuan terrytangyuan self-requested a review October 9, 2021 16:24
@terrytangyuan terrytangyuan self-assigned this Oct 9, 2021
terrytangyuan
terrytangyuan reviewed Oct 9, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes look good. Would you like to add an example for this that's being tested in the CI? You can follow the existing examples on configmapRef.

@smile-luobin
Add ci test and fix lint
71673bf 
Signed-off-by: smile-luobin <luobin_smile@163.com>
@smile-luobin
Copy link
Contributor Author

Thanks! The changes look good. Would you like to add an example for this that's being tested in the CI? You can follow the existing examples on configmapRef.

done

@smile-luobin
fix check codegen
86e06bb 
Signed-off-by: smile-luobin <luobin_smile@163.com>
terrytangyuan
terrytangyuan approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for your contribution!

@terrytangyuan terrytangyuan merged commit 6384e5f into argoproj:master Oct 19, 2021
@sarabala1979 sarabala1979 mentioned this pull request Oct 21, 2021
Closed
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
@smile-luobin @kriti-sc
feat: fix workflow configmap argument cannot be referenced as local v…
e4a422c 
…ariable. Fixes argoproj#6869 (argoproj#6898)

Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@terrytangyuan terrytangyuan mentioned this pull request Oct 26, 2021
Closed
@sarabala1979 sarabala1979 mentioned this pull request Nov 9, 2021
Closed
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
Closed
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees

@terrytangyuan terrytangyuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smile-luobin @terrytangyuan